sunchao commented on a change in pull request #34715:
URL: https://github.com/apache/spark/pull/34715#discussion_r763299256
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -98,7 +98,9 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
mirrors.distinct :+ "https://archive.apache.org/dist"; :+
PROCESS_TABLES.releaseMirror
logInfo(s"Trying to download Spark $version from $sites")
for (site <- sites) {
- val filename = if (version.startsWith("3")) {
+ val filename = if (version.startsWith("3.3")) {
Review comment:
hmm seems this is not addressed, what if Spark 3.3 is released and
`version` is 3.4, do we need update here again like:
```scala
val filename = if (version.startsWith("3.3") || version.startsWith("3.4")) {
s"spark-$version-bin-hadoop3.tgz"
} else if (version.startsWith("3")) {
s"spark-$version-bin-hadoop3.2.tgz"
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
