Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6070#discussion_r30104334
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -662,6 +664,16 @@ object StreamingContext extends Logging {
         }
       }
     
    +  /**
    +   * Get the context that is currently active, that is, started but not 
stopped.
    +   */
    +  @Experimental
    +  def getActive(): Option[StreamingContext] = {
    +    ACTIVATION_LOCK.synchronized {
    +      Option(activeContext.get())
    --- End diff --
    
    I'm a bit confused about the locking here. What if I call start() then 
stop() currently on the same streamingContext in different threads. Can't I 
have a race condition where the stop() calls `setActiveContext(null)` between 
the following lines:
    
    ```
    t1: state = StreamingContextState.ACTIVE
    t2:   --> setActiveContext(null)
    t1: setActiveContext(this)
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to