zero323 commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r764261612
##########
File path: python/pyspark/context.py
##########
@@ -327,24 +360,24 @@ def _do_init(
dump_path = self._conf.get("spark.python.profile.dump", None)
self.profiler_collector = ProfilerCollector(profiler_cls,
udf_profiler_cls, dump_path)
else:
- self.profiler_collector = None
+ self.profiler_collector = None # type: ignore[assignment]
# create a signal handler which would be invoked on receiving SIGINT
- def signal_handler(signal, frame):
+ def signal_handler(signal: Any, frame: Any) -> NoReturn:
Review comment:
I was thinking more about narrowing down the types than direct copy and
paste, but it is probably OK to keep it as-is for now ‒ it is deep internals
anyway, and unlikely to be silently broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
