LuciferYang commented on a change in pull request #34829:
URL: https://github.com/apache/spark/pull/34829#discussion_r764527144



##########
File path: 
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileWriters.scala
##########
@@ -229,6 +232,15 @@ class SingleEventLogFileWriter(
     writeLine(eventJson, flushLogger)
   }
 
+  override def writeToXAttr(attrName: String, attrValue: String): Unit = {
+    try {
+      fileSystem.setXAttr(new Path(inProgressPath), attrName, 
attrValue.getBytes())
+    } catch {
+      case _: IOException =>

Review comment:
       We may also need to handle `UnsupportedOperationException` , some fs do 
not really implement `setXAttr` interface, such as 
`o.a.hadoop.fs.RawLocalFileSystem`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to