huaxingao commented on a change in pull request #34799:
URL: https://github.com/apache/spark/pull/34799#discussion_r764617946
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -208,6 +208,9 @@ abstract class JdbcDialect extends Serializable with
Logging{
case max: Max =>
if (max.column.fieldNames.length != 1) return None
Some(s"MAX(${quoteIdentifier(max.column.fieldNames.head)})")
+ case avg: Average =>
Review comment:
In Spark, partial aggregate output for avg is a sequence of (sum,
count). If we want to push down partial aggregate of avg to data source, should
we also use sum and count?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
