masseyke commented on pull request #34838: URL: https://github.com/apache/spark/pull/34838#issuecomment-989885218
> Looks good but how did you test this? it would be great to keep GitHub PR template: https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE. Also Apache Spark uses GitHub Actions from forked repository, see also https://github.com/apache/spark/pull/34838/checks?check_run_id=4459879248 I didn't see an existing unit test for that class, so I manually tested it by creating a mapping with a short field in Elasticsearch, and then reading that data with es-spark (it fails before the patch). I can put the template back in and add a jira ticket. I believe I've enabled github actions now (not completely sure) but I don't know how to re-trigger the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
