sunchao commented on a change in pull request #34830:
URL: https://github.com/apache/spark/pull/34830#discussion_r766108654
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -55,7 +55,8 @@ private[hive] object IsolatedClientLoader extends Logging {
sharedPrefixes: Seq[String] = Seq.empty,
barrierPrefixes: Seq[String] = Seq.empty): IsolatedClientLoader =
synchronized {
val resolvedVersion = hiveVersion(hiveMetastoreVersion)
- // We will use Hadoop 2.7 if we cannot resolve the Hadoop artifact.
+ // We will use hadoop-3.3.1 if we can't resolve the hadoop artifact
+ // when builtin hadoop is Hadoop 3. Otherwise we will use hadoop-2.4.7.
Review comment:
`Otherwise we will use hadoop-2.4.7.` -> `Otherwise we will use Hadoop
2.x`.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -55,7 +55,8 @@ private[hive] object IsolatedClientLoader extends Logging {
sharedPrefixes: Seq[String] = Seq.empty,
barrierPrefixes: Seq[String] = Seq.empty): IsolatedClientLoader =
synchronized {
val resolvedVersion = hiveVersion(hiveMetastoreVersion)
- // We will use Hadoop 2.7 if we cannot resolve the Hadoop artifact.
+ // We will use hadoop-3.3.1 if we can't resolve the hadoop artifact
Review comment:
nit: maybe `hadoop-3.3.1` -> `hadoop-3.x` so we don't need to update
here every time we upgrade Hadoop 3.x version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
