imback82 commented on a change in pull request #34861:
URL: https://github.com/apache/spark/pull/34861#discussion_r766400035
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/CatalogSuite.scala
##########
@@ -858,16 +858,16 @@ class CatalogSuite extends SparkFunSuite {
catalog.alterNamespace(testNs, NamespaceChange.setProperty("property2",
"value2"))
assert(catalog.loadNamespaceMetadata(testNs).asScala === Map(
- "property" -> "value", "property2" -> "value2"))
+ "property2" -> "value2"))
Review comment:
This is where the behavior can change based on the catalog
implementation, and I don't think we are documenting what's the expected
behavior of handling existing properties for `alterNamespace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
