AngersZhuuuu commented on a change in pull request #34847:
URL: https://github.com/apache/spark/pull/34847#discussion_r766473638
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##########
@@ -836,8 +837,15 @@ case class CustomFileCommitProtocol(
dynamicPartitionOverwrite: Boolean = false)
extends SQLHadoopMapReduceCommitProtocol(jobId, path,
dynamicPartitionOverwrite) {
override def commitTask(
- taskContext: TaskAttemptContext): FileCommitProtocol.TaskCommitMessage = {
- Thread.sleep(Random.nextInt(100))
+ taskContext: TaskAttemptContext): FileCommitProtocol.TaskCommitMessage =
{
+ Thread.sleep(1000)
Review comment:
> if the goal is to make sure the commit time > 0, how about we sleep
100 ms?
Yea, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
