imback82 commented on a change in pull request #34861:
URL: https://github.com/apache/spark/pull/34861#discussion_r766877252
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterNamespaceSetPropertiesExec.scala
##########
@@ -29,7 +31,8 @@ case class AlterNamespaceSetPropertiesExec(
namespace: Seq[String],
props: Map[String, String]) extends LeafV2CommandExec {
override protected def run(): Seq[InternalRow] = {
- val changes = props.map{ case (k, v) =>
+ val existingProps =
catalog.loadNamespaceMetadata(namespace.toArray).asScala.toMap
+ val changes = (existingProps ++ props).map { case (k, v) =>
NamespaceChange.setProperty(k, v)
Review comment:
OK, makes sense. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
