sunchao commented on a change in pull request #34857:
URL: https://github.com/apache/spark/pull/34857#discussion_r766889861
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -435,6 +426,22 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
RefreshFunctionCommand(funcIdentifier.database, funcIdentifier.funcName)
}
+ private def constructTableV1Cmd(
Review comment:
nit: `constructV1TableCmd`?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -479,48 +479,24 @@ object QueryCompilationErrors {
new AnalysisException("ADD COLUMN with v1 tables cannot specify NOT NULL.")
}
- def replaceColumnsOnlySupportedWithV2TableError(): Throwable = {
- new AnalysisException("REPLACE COLUMNS is only supported with v2 tables.")
- }
-
- def alterQualifiedColumnOnlySupportedWithV2TableError(): Throwable = {
- new AnalysisException("ALTER COLUMN with qualified column is only
supported with v2 tables.")
+ def operationOnlySupportedWithV2TableError(message: String): Throwable = {
Review comment:
nit: `message` -> `command` or `operation`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
