HyukjinKwon commented on a change in pull request #34853:
URL: https://github.com/apache/spark/pull/34853#discussion_r767101873
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
##########
@@ -95,7 +95,7 @@ class UnivocityGenerator(
if (!row.isNullAt(i)) {
values(i) = valueConverters(i).apply(row, i)
} else {
- values(i) = options.nullValue
+ values(i) = null
Review comment:
I see. So Univocity will write out the values for actual `null`s. I
think we can even just don't explicitly set `null`s `here`. e.g.)
```scala
if (!row.isNullAt(i)) {
values(i) = valueConverters(i).apply(row, i)
}
```
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala
##########
@@ -95,7 +95,7 @@ class UnivocityGenerator(
if (!row.isNullAt(i)) {
values(i) = valueConverters(i).apply(row, i)
} else {
- values(i) = options.nullValue
+ values(i) = null
Review comment:
I see. So Univocity will write out the values for actual `null`s. I
think we can even just don't explicitly set `null`s. e.g.)
```scala
if (!row.isNullAt(i)) {
values(i) = valueConverters(i).apply(row, i)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
