srowen commented on a change in pull request #34846:
URL: https://github.com/apache/spark/pull/34846#discussion_r767166790
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -3204,6 +3205,33 @@ private[spark] object Utils extends Logging {
}
files.toSeq
}
+
+ private def isG1GarbageCollector: Boolean = {
Review comment:
Can this be a `val`? I don't think it will change
Likewise could you just try to get G1HeapRegionSize once here? if it's not
G1GC, just store "None". Then you don't check it each time. Because I think
this can't change during the JVM's lifetime.
Then you don't need a utility method below, even
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
