dongjoon-hyun commented on a change in pull request #34599:
URL: https://github.com/apache/spark/pull/34599#discussion_r767224331
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -133,22 +133,37 @@ private[spark] class Client(
.build()
val driverPodName = resolvedDriverPod.getMetadata.getName
+ // setup resources before pod creation
+ val preKubernetesResources =
resolvedDriverSpec.driverPreKubernetesResources
+ try {
+ kubernetesClient.resourceList(preKubernetesResources:
_*).createOrReplace()
+ } catch {
+ case NonFatal(e) =>
+ kubernetesClient.resourceList(preKubernetesResources: _*).delete()
+ throw e
+ }
+
var watch: Watch = null
var createdDriverPod: Pod = null
try {
createdDriverPod = kubernetesClient.pods().create(resolvedDriverPod)
} catch {
case NonFatal(e) =>
+ kubernetesClient.resourceList(preKubernetesResources: _*).delete()
logError("Please check \"kubectl auth can-i create pod\" first. It
should be yes.")
throw e
}
+
+ // setup resources after pod creation, and refresh all resources owner
references
try {
- val otherKubernetesResources =
resolvedDriverSpec.driverKubernetesResources ++ Seq(configMap)
+ val otherKubernetesResources =
resolvedDriverSpec.driverKubernetesResources ++
+ preKubernetesResources ++ Seq(configMap)
Review comment:
Please handle `preKubernetesResources` separately before
`driverKubernetesResources`, @Yikun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
