tanelk commented on a change in pull request #34867:
URL: https://github.com/apache/spark/pull/34867#discussion_r767132141
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -46,9 +46,11 @@ import org.apache.spark.util.Utils
*/
object ReplaceExpressions extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan =
plan.transformAllExpressionsWithPruning(
- _.containsAnyPattern(RUNTIME_REPLACEABLE, COUNT_IF, BOOL_AGG)) {
+ _.containsAnyPattern(RUNTIME_REPLACEABLE, COUNT_IF, BOOL_AGG, REGR_COUNT))
{
case e: RuntimeReplaceable => e.child
case CountIf(predicate) => Count(new NullIf(predicate,
Literal.FalseLiteral))
+ case RegrCount(left, right) =>
+ Count(new NullIf(Or(IsNull(left), IsNull(right)), Literal.TrueLiteral))
Review comment:
Isn't this what `count(left, right)` does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
