Kwafoor commented on a change in pull request #34862:
URL: https://github.com/apache/spark/pull/34862#discussion_r767232024
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -652,7 +652,13 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
buildCast[UTF8String](_, UTF8StringUtils.toIntExact)
case StringType =>
val result = new IntWrapper()
- buildCast[UTF8String](_, s => if (s.toInt(result)) result.value else
null)
+ buildCast[UTF8String](_, s => {
+ if (s.toInt(result)) {
+ result.value}
Review comment:
This case is some users use HiveSQL in SparkSQL, when cast the value of
string exceed Int.MaxValue to integer,SparkSQL return null.It will make big
trouble, because user didn't get any exception, but the result is wrong.I think
SparkSQL should thrown exception at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
