cloud-fan commented on a change in pull request #34738:
URL: https://github.com/apache/spark/pull/34738#discussion_r767463616
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -246,16 +247,42 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
}
}
+ private def pushDownLimit(plan: LogicalPlan, limit: Int): LogicalPlan = plan
match {
+ case operation @ ScanOperation(_, filter, sHolder: ScanBuilderHolder) if
filter.isEmpty =>
+ val limitPushed = PushDownUtils.pushLimit(sHolder.builder, limit)
+ if (limitPushed) {
+ sHolder.pushedLimit = Some(limit)
+ }
+ operation
+ case s @ Sort(order, _, operation @ ScanOperation(_, filter, sHolder:
ScanBuilderHolder))
+ if filter.isEmpty =>
+ val orders = DataSourceStrategy.translateSortOrders(order)
+ val topNPushed = PushDownUtils.pushTopN(sHolder.builder, orders.toArray,
limit)
+ if (topNPushed) {
+ sHolder.pushedLimit = Some(limit)
+ sHolder.sortValues = orders
+ operation
+ } else {
+ s
+ }
+ case p: Project =>
+ val newChild = pushDownLimit(p.child, limit)
+ if (newChild == p.child) {
+ p
+ } else {
+ p.copy(child = newChild)
+ }
+ case other => other
+ }
+
def applyLimit(plan: LogicalPlan): LogicalPlan = plan.transform {
case globalLimit @ Limit(IntegerLiteral(limitValue), child) =>
- child match {
- case ScanOperation(_, filter, sHolder: ScanBuilderHolder) if
filter.length == 0 =>
- val limitPushed = PushDownUtils.pushLimit(sHolder.builder,
limitValue)
- if (limitPushed) {
- sHolder.pushedLimit = Some(limitValue)
- }
- globalLimit
- case _ => globalLimit
+ val newChild = pushDownLimit(child, limitValue)
+ if (newChild == child) {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
