GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/6076
[SPARK-7500] DAG visualization: move cluster labeling to dagre-d3
This fixes the label bleeding issue described in the JIRA. I also took the
opportunity to move some code to the places that they belong more to. In
particular:
(1) Drawing cluster labels is now implemented in my branch of dagre-d3
instead of in Spark
(2) All graph styling is now moved from Scala to JS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark dag-viz-bleed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6076
----
commit 4a4fb58bc7f66697aaddcd8b0980c838ebd5b433
Author: Andrew Or <[email protected]>
Date: 2015-05-12T08:09:51Z
Fix bleeding + move all styling to JS
This commit does three major things:
(1) The bleeding issue is fixed. This requires modifications in
dagre-d3 itself to expand the node margins when the enclosing
cluster has a long title.
(2) We moved the label generating logic from our own script to
dagre-d3 itself. This is such that we don't have to maintain
such general logic ourselves in Spark.
(3) We moved all styling from Scala to JS. This is mainly an
effort to separate the DOT generation logic from the actual
rendering logic
commit d908c36c03cab1ef95d53003e49a9fac5bb31840
Author: Andrew Or <[email protected]>
Date: 2015-05-12T08:17:07Z
Add link to dagre-d3 changes (minor)
commit c686dc4ac611fa161ab9edfac2baa631d892596d
Author: Andrew Or <[email protected]>
Date: 2015-05-12T08:19:15Z
Fix tooltip placement
So that it does not leak beyond the SVG boundaries.
commit a0da7c199b646ccff60421cab86f1c9a54840cd9
Author: Andrew Or <[email protected]>
Date: 2015-05-12T08:19:38Z
Merge branch 'master' of github.com:apache/spark into dag-viz-bleed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
