pan3793 commented on a change in pull request #34831:
URL: https://github.com/apache/spark/pull/34831#discussion_r767497436
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
##########
@@ -139,14 +139,7 @@ private[spark] class NettyBlockTransferService(
}
}
}
-
- if (maxRetries > 0) {
- // Note this Fetcher will correctly handle maxRetries == 0; we avoid
it just in case there's
- // a bug in this code. We should remove the if statement once we're
sure of the stability.
Review comment:
Sound like add unit test cases in `RetryingBlockTransferorSuite` is more
reasonable, will update soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
