zero323 commented on pull request #34363: URL: https://github.com/apache/spark/pull/34363#issuecomment-992434036
> @zero323 Do you have any ideas to resolve this PR? Not at the moment and I don't have much time to investigate it further. If you no one has any inputs, and you feel like it, you can try to reduce the [snippets](https://github.com/apache/spark/pull/34363#discussion_r760622451) and ask mypy folks, if that's expected behavior for some reason, or just a bug. If the latter, we can just `type: ingore`, if the former we can try to think about other approaches. > Should I keep both `__add__` and `__iadd__` That's clearly not what we expect here. There is no requirement for us to have both `__iadd__` and `__add__` implemented. We could be more subtle at some point and have something like `Union[SupportsIAdd, SupportsAdd]`, but that's really not the point here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
