zero323 commented on a change in pull request #34433:
URL: https://github.com/apache/spark/pull/34433#discussion_r768054438
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -2530,7 +2531,9 @@ def replace( # type: ignore[misc]
to_replace: Union[
"LiteralType", List["LiteralType"], Dict["LiteralType",
"OptionalPrimitiveType"]
],
- value: Optional[Union["OptionalPrimitiveType",
List["OptionalPrimitiveType"]]] = _NoValue,
+ value: Optional[
+ Union["OptionalPrimitiveType", List["OptionalPrimitiveType"],
_NoValueType]
+ ] = _NoValue,
Review comment:
OK, I gave it another look and any changes to `pyspark.sql` seem to
unnecessary for the core task (in-lining of `pyspark/__init__.py`) ‒ the whole
type checking pipeline passes just fine when omit `pyspark.sql` changes.
So let's resolve the conflicts, revert whatever is not strictly necessary,
double check and get this merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
