HyukjinKwon commented on a change in pull request #34893:
URL: https://github.com/apache/spark/pull/34893#discussion_r768503399
##########
File path: python/pyspark/pandas/utils.py
##########
@@ -464,20 +464,12 @@ def is_testing() -> bool:
return "SPARK_TESTING" in os.environ
-def default_session(conf: Optional[Dict[str, Any]] = None) -> SparkSession:
- if conf is None:
- conf = dict()
+def default_session() -> SparkSession:
+ spark = SparkSession.getActiveSession()
+ if spark is not None:
+ return spark
builder = SparkSession.builder.appName("pandas-on-Spark")
- for key, value in conf.items():
- builder = builder.config(key, value)
- # Currently, pandas-on-Spark is dependent on such join due to
'compute.ops_on_diff_frames'
- # configuration. This is needed with Spark 3.0+.
- builder.config("spark.sql.analyzer.failAmbiguousSelfJoin", False)
-
- if is_testing():
- builder.config("spark.executor.allowSparkContext", False)
Review comment:
and this will be set separately when SparkContext is created, not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
