Ngone51 commented on a change in pull request #34834:
URL: https://github.com/apache/spark/pull/34834#discussion_r768851497
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -960,19 +960,27 @@ private[spark] class TaskSetManager(
assert (null != failureReason)
taskSetExcludelistHelperOpt.foreach(_.updateExcludedForFailedTask(
info.host, info.executorId, index, failureReason))
- numFailures(index) += 1
- if (numFailures(index) >= maxTaskFailures) {
- logError("Task %d in stage %s failed %d times; aborting job".format(
- index, taskSet.id, maxTaskFailures))
- abort("Task %d in stage %s failed %d times, most recent failure:
%s\nDriver stacktrace:"
- .format(index, taskSet.id, maxTaskFailures, failureReason),
failureException)
- return
+ if (!successful(index)) {
Review comment:
`numFailures` is only used to count continuous failures of a task. So, I
think it may be a better fix to unset `numFailures` instead when the task
succeeds by one of the attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
