sunchao commented on a change in pull request #34471:
URL: https://github.com/apache/spark/pull/34471#discussion_r768903287
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DataSourceReadBenchmark.scala
##########
@@ -147,6 +159,16 @@ object DataSourceReadBenchmark extends SqlBasedBenchmark {
}
}
+ sqlBenchmark.addCase("SQL Parquet Vectorized (Delta Binary)") { _ =>
Review comment:
Right, Boolean is encoded as RLE in Parquet format V2, so we'd need to
handle it too. I think we should raise a separate PR for this.
For now, can you remove the changes in `DataSourceReadBenchmark` and split
it out into a separate PR later once we have the boolean type supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
