venkata91 commented on a change in pull request #33896:
URL: https://github.com/apache/spark/pull/33896#discussion_r768926348
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3847,10 +3890,201 @@ class DAGSchedulerSuite extends SparkFunSuite with
TempLocalSparkContext with Ti
// Job successful ended.
assert(results === Map(0 -> 11, 1 -> 12))
+ }
+
Review comment:
This could be difficult to test since for tests we are not waiting for
the delay (eg: 10 secs) to expire and also not running merge finalization in a
separate thread. All the DAGScheduler events are synchronized so once all the
tasks complete for a stage shuffle merge finalization would complete in the
tests (but in the real code we would wait for the 10 secs or whatever
configured) so there if minimum pushes complete then that gets cancelled and
replaced with a new `finalize` with delay = 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
