sunchao commented on a change in pull request #34659:
URL: https://github.com/apache/spark/pull/34659#discussion_r769131591
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
##########
@@ -350,6 +355,14 @@ public WritableColumnVector reserveDictionaryIds(int
capacity) {
*/
public abstract void putArray(int rowId, int offset, int length);
+ /**
+ * Puts a new non-null struct at 'rowId' of this vector, which is backed by
elements at
+ * 'offset' of child vectors.
+ *
+ * NOTE: this MUST be called after new elements are appended to child
vectors of a struct vector.
+ */
+ public abstract void putStruct(int rowId, int offset);
Review comment:
I want to point out that this is a behavior change in
`WritableColumnVector` so anyone who's using this to write struct will need to
adopt to the new API.
Wanna see if you have any concern on this @cloud-fan @sadikovi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
