LuciferYang commented on a change in pull request #34881:
URL: https://github.com/apache/spark/pull/34881#discussion_r769221468
##########
File path: dev/deps/spark-deps-hadoop-2-hive-2.3
##########
@@ -197,7 +197,40 @@ metrics-jmx/4.2.2//metrics-jmx-4.2.2.jar
metrics-json/4.2.2//metrics-json-4.2.2.jar
metrics-jvm/4.2.2//metrics-jvm-4.2.2.jar
minlog/1.3.0//minlog-1.3.0.jar
-netty-all/4.1.68.Final//netty-all-4.1.68.Final.jar
+netty-all/4.1.71.Final//netty-all-4.1.71.Final.jar
+netty-buffer/4.1.71.Final//netty-buffer-4.1.71.Final.jar
Review comment:
> Whoa, this doesn't look right. netty-all is (probably?) a packaging of
all these subcomponents.
Something changes in how it's declared. We might need to depend just on
pieces of netty 4.1.71?
The change occurred after version 4.1.69, [Netty#11732 netty-all should not
re-package jars](https://github.com/netty/netty/pull/11732).
@srowen Do you mean that we need to introduce only the sub modules we really
use? I think it's OK
But we originally introduced all Netty modules before 4.1.68 through use
`netty-all-4.1.68.Final.jar`. If we introduce subsets instead, will it cause
some user compatibility problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
