itholic commented on a change in pull request #34886:
URL: https://github.com/apache/spark/pull/34886#discussion_r769269607
##########
File path: python/pyspark/pandas/groupby.py
##########
@@ -3327,15 +3326,9 @@ def normalize_keyword_aggregation(
Examples
--------
>>> normalize_keyword_aggregation({'output': ('input', 'sum')})
- (OrderedDict([('input', ['sum'])]), ['output'], [('input', 'sum')])
+ (defaultdict(<class 'list'>, {'input': ['sum']}), ['output'], [('input',
'sum')])
Review comment:
Then we maybe should address the description in the line 3310-3311 ?
From
`Transforms from the new ``Dict[str, NamedAgg]`` style kwargs to the old
OrderedDict[str, List[scalar]]].`
to
`Transforms from the new ``Dict[str, NamedAgg]`` style kwargs to the old
defaultdict[str, List[scalar]]].`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
