attilapiros commented on a change in pull request #34846:
URL: https://github.com/apache/spark/pull/34846#discussion_r769731048
##########
File path: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
##########
@@ -244,17 +245,26 @@ private[spark] abstract class MemoryManager(
* and then divide it by a factor of safety.
*/
val pageSizeBytes: Long = {
- val minPageSize = 1L * 1024 * 1024 // 1MB
- val maxPageSize = 64L * minPageSize // 64MB
- val cores = if (numCores > 0) numCores else
Runtime.getRuntime.availableProcessors()
- // Because of rounding to next power of 2, we may have safetyFactor as 8
in worst case
- val safetyFactor = 16
- val maxTungstenMemory: Long = tungstenMemoryMode match {
- case MemoryMode.ON_HEAP => onHeapExecutionMemoryPool.poolSize
- case MemoryMode.OFF_HEAP => offHeapExecutionMemoryPool.poolSize
+ val default = Utils.G1HeapRegionSize match {
Review comment:
lazy val
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
