srowen commented on a change in pull request #34881:
URL: https://github.com/apache/spark/pull/34881#discussion_r769746455



##########
File path: dev/deps/spark-deps-hadoop-3-hive-2.3
##########
@@ -184,7 +184,40 @@ metrics-jmx/4.2.2//metrics-jmx-4.2.2.jar
 metrics-json/4.2.2//metrics-json-4.2.2.jar
 metrics-jvm/4.2.2//metrics-jvm-4.2.2.jar
 minlog/1.3.0//minlog-1.3.0.jar
-netty-all/4.1.68.Final//netty-all-4.1.68.Final.jar
+netty-all/4.1.72.Final//netty-all-4.1.72.Final.jar

Review comment:
       I see, so netty-all no longer has the contents of all the JARs below, so 
it's not redundant? that is OK if so. We could even exclude probably lots of 
these (SMTP? SOCKS?). Not necessary but might be nice if they're largeish and 
unused.
   
   BTW the description says this updates log4j, but, log4j 2 is not in the 
build before or after this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to