AngersZhuuuu commented on a change in pull request #34695:
URL: https://github.com/apache/spark/pull/34695#discussion_r770182367



##########
File path: core/src/main/resources/org/apache/spark/ui/static/utils.js
##########
@@ -205,6 +205,29 @@ function createRESTEndPointForExecutorsPage(appId) {
   return uiRoot + "/api/v1/applications/" + appId + "/allexecutors";
 }
 
+function createRESTEndPointForExecutorsPeakMetricsSummariesPage(appId) {
+  var words = getBaseURI().split('/');

Review comment:
       > It seems like most of the logic here is duplicated with 
`createRESTEndPointForExecutorsPage` except for the REST call. Can we refactor 
it a bit and avoid/reduce the redundant code?
   
   It belongs to different api,  `allexecutors` return the list of all 
executor's summaries. It's hard to combine `/allexecutors` and 
`/executorPeakMemoryMetricsDistribution `




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to