cloud-fan commented on a change in pull request #34880:
URL: https://github.com/apache/spark/pull/34880#discussion_r770233966



##########
File path: sql/core/src/test/resources/sql-tests/inputs/group-by.sql
##########
@@ -204,3 +207,13 @@ FROM VALUES
  (21), (22), (23), (24), (25), (26), (27), (28), (29), (30),
  (31), (32), (33), (34), (35), (3), (37), (38), (39), (40),
  (41), (42), (43), (44), (45), (46), (47), (48), (49), (50) AS tab(col);
+
+-- SPARK-37613: Support ANSI Aggregate Function: regr_count
+SELECT regr_count(b, a) FROM VALUES (1, 2L), (2, 2L), (2, 3L), (2, 4L) AS 
tab(a, b);
+SELECT regr_count(b, a) FROM VALUES (1, 2L), (2, null), (2, 3L), (2, 4L) AS 
tab(a, b);
+SELECT regr_count(b, a) FROM VALUES (1, 2L), (2, null), (null, 3L), (2, 4L) AS 
tab(a, b);
+SELECT a, regr_count(b, a) FROM VALUES (1, 2D), (2, 2L), (2, 3D), (2, 4D) AS 
tab(a, b) group by a;
+SELECT a, regr_count(b, a) FROM VALUES (1, 2D), (2, null), (2, 3D), (2, 4D) AS 
tab(a, b) group by a;
+SELECT a, regr_count(b, a) FROM VALUES (1, 2D), (2, null), (null, 3D), (2, 4D) 
AS tab(a, b) group by a;
+SELECT regr_count(y, x) FROM testRegression;

Review comment:
       Then can we use it consistently and change `FROM VALUES...` to `FROM 
testRegression` in the tests above?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to