cloud-fan commented on a change in pull request #34914:
URL: https://github.com/apache/spark/pull/34914#discussion_r770236588
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -112,15 +112,9 @@ private[sql] final case class BucketTransform(
arguments.collect { case named: NamedReference => named }
}
- override def arguments: Array[Expression] = numBuckets +: columns.toArray
+ override def arguments: Array[Expression] = (numBuckets +: columns.toArray)
++ sortedColumns
Review comment:
does this really work? I don't see a way for people to extract bucket
and sort columns from arguments with the `Transform` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
