Yikun edited a comment on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-995571901
> This PR doesn't have a test case. Could you add a test coverage for your code path please? Sure, thanks for reminder, I have added the testcase in latest commit. > could you elaborate why we need to create some resource before driver pod creation? These resources are usually necessary in pod creation and scheduling, they should be ready before pod creation, should be deleted when user delete pod, the lifecycle of these resource is same with pod, there are some scenarioes: - Extension custom resources, they are usually created in k8s or cncf extension compoent, such as the customized batch scheduler scenario, the user need to create the addtional pre resources (such as pod group in Volcano) to help the specific spark job complete batch scheduling. - The temporary priority class, the priority class is created in custom feature step for specific job and also is epected to be deleted when job deleted. @dongjoon-hyun Much thank for your patient and guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
