ueshin commented on a change in pull request #34926:
URL: https://github.com/apache/spark/pull/34926#discussion_r771047045
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -9651,7 +9651,7 @@ def stack(self) -> DataFrameOrSeries:
).with_filter(SF.lit(False))
)
- column_labels: Union[defaultdict, OrderedDict] = defaultdict(dict)
+ column_labels: Dict[Label, Dict[Any, Column]] = defaultdict(dict)
Review comment:
`column_labels` will be re-assinged at
https://github.com/apache/spark/blob/93b21059d26bf1e88ad4101b71d0dae7bf4a6c5c/python/pyspark/pandas/frame.py#L9669
I think it's okay to use more generic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
