LuciferYang commented on a change in pull request #33628:
URL: https://github.com/apache/spark/pull/33628#discussion_r771230090
##########
File path:
core/src/test/scala/org/apache/spark/storage/DiskBlockObjectWriterSuite.scala
##########
@@ -184,4 +184,20 @@ class DiskBlockObjectWriterSuite extends SparkFunSuite
with BeforeAndAfterEach {
writer.close()
assert(segment.length === 0)
}
+
+ test("calling closeAndDelete() on a partial write file") {
+ val (writer, file, writeMetrics) = createWriter()
+
+ writer.write(Long.box(20), Long.box(30))
+ val firstSegment = writer.commitAndGet()
+ assert(firstSegment.length === file.length())
+ assert(writeMetrics.bytesWritten === file.length())
+
+ writer.write(Long.box(40), Long.box(50))
+
+ writer.closeAndDelete()
+ assert(!file.exists())
+ assert(writeMetrics.bytesWritten === firstSegment.length)
Review comment:
I add a new case, the current value of `writeMetrics` is the value after
the last `commitAndGet` now. I think we should reset values of `writeMetrics`
to 0 because the file no longer exists. What do you think? @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
