wangshengjie123 commented on a change in pull request #34834:
URL: https://github.com/apache/spark/pull/34834#discussion_r771839830
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -820,6 +820,7 @@ private[spark] class TaskSetManager(
s"on ${info.host} (executor ${info.executorId})
($tasksSuccessful/$numTasks)")
// Mark successful and stop if all the tasks have succeeded.
successful(index) = true
+ numFailures(index) = 0
Review comment:
Shall we update the doc comment for spark.task.maxFailures ? Sorry about
that maybe I don't understand your intention very clearly， @mridulm
And i prefer not to reset `numFailures` when setting `successful(index) =
true` if task failed due to FetchFailed
(https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L877),
it seems just to avoid submitting a retry task, am i right ? @mridulm @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
