Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6073#discussion_r30156891
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -87,12 +87,15 @@ class NaiveBayesModel private[mllib] (
}
override def predict(testData: Vector): Double = {
+ val brzData = testData.toBreeze
modelType match {
case "Multinomial" =>
- labels (brzArgmax (brzPi + brzTheta * testData.toBreeze) )
+ labels (brzArgmax (brzPi + brzTheta * brzData) )
case "Bernoulli" =>
+ brzData.foreach(v => if (!(v == 0.0 || v == 1.0))
--- End diff --
Fix Scala style for multi-line closure, and branch a little less:
```
if (!brzData.forall(v => v == 0.0 || v == 1.0)) {
throw new SparkException(
s"Bernoulli Naive Bayes requires feature values 0 or 1 but found
feature vector $testData.")
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
