cloud-fan commented on a change in pull request #33946:
URL: https://github.com/apache/spark/pull/33946#discussion_r772171364
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -987,10 +987,10 @@ object CollapseRepartition extends Rule[LogicalPlan] {
case (false, true) => if (r.numPartitions >= child.numPartitions) child
else r
case _ => r.copy(child = child.child)
}
- // Case 2: When a RepartitionByExpression has a child of Repartition or
RepartitionByExpression
- // we can remove the child.
- case r @ RepartitionByExpression(_, child: RepartitionOperation, _) =>
- r.copy(child = child.child)
+ // Case 2: When a RepartitionByExpression has a child of Sort, Repartition
or
+ // RepartitionByExpression we can remove the child.
+ case r @ RepartitionByExpression(_, child @ (_: Sort | _:
RepartitionOperation), _) =>
Review comment:
is it possible that Spark can keep the ordering in some cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
