Ngone51 commented on a change in pull request #34961:
URL: https://github.com/apache/spark/pull/34961#discussion_r772350991
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -1301,9 +1301,12 @@ private class BufferReleasingInputStream(
block
} catch {
case e: IOException if detectCorruption =>
- val diagnosisResponse = checkedInOpt.map { checkedIn =>
- iterator.diagnoseCorruption(checkedIn, address, blockId)
- }
+ val diagnosisResponse = checkedInOpt
+ // TODO SPARK-36284 Add shuffle checksum support for push-based
shuffle
+ .filterNot { _ => blockId.isShuffleChunk }
+ .map { checkedIn =>
+ iterator.diagnoseCorruption(checkedIn, address, blockId)
+ }
Review comment:
Shall we do the check inside `diagnoseCorruption()` to ensure other
calls on it are also safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
