viirya commented on a change in pull request #34895:
URL: https://github.com/apache/spark/pull/34895#discussion_r772732483
##########
File path: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala
##########
@@ -51,17 +54,18 @@ private[spark] class DriverLogger(conf: SparkConf) extends
Logging {
addLogAppender()
private def addLogAppender(): Unit = {
- val appenders = LogManager.getRootLogger().getAllAppenders()
+ val logger = LogManager.getRootLogger().asInstanceOf[Logger]
val layout = if (conf.contains(DRIVER_LOG_LAYOUT)) {
- new PatternLayout(conf.get(DRIVER_LOG_LAYOUT).get)
- } else if (appenders.hasMoreElements()) {
- appenders.nextElement().asInstanceOf[Appender].getLayout()
+
PatternLayout.newBuilder().withPattern(conf.get(DRIVER_LOG_LAYOUT).get).build()
} else {
- new PatternLayout(DEFAULT_LAYOUT)
+ PatternLayout.newBuilder().withPattern(DEFAULT_LAYOUT).build()
}
- val fa = new Log4jFileAppender(layout, localLogFile)
- fa.setName(DriverLogger.APPENDER_NAME)
- LogManager.getRootLogger().addAppender(fa)
+ val config = logger.getContext.getConfiguration()
+ val fa = Log4jFileAppender.createAppender(localLogFile, "false", "false",
+ DriverLogger.APPENDER_NAME, "true", "false", "false", "4000", layout,
null,
+ "false", null, config);
Review comment:
I think we can rewrite it using builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
