cloud-fan commented on a change in pull request #34575:
URL: https://github.com/apache/spark/pull/34575#discussion_r772971151
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
##########
@@ -171,6 +171,29 @@ trait FileFormat {
def supportFieldName(name: String): Boolean = true
}
+object FileFormat {
+
+ val FILE_PATH = "file_path"
+
+ val FILE_NAME = "file_name"
+
+ val FILE_SIZE = "file_size"
+
+ val FILE_MODIFICATION_TIME = "file_modification_time"
+
+ val METADATA_NAME = "_metadata"
+
+ // supported metadata struct fields for hadoop fs relation
+ val METADATA_STRUCT: StructType = new StructType()
+ .add(StructField(FILE_PATH, StringType))
+ .add(StructField(FILE_NAME, StringType))
+ .add(StructField(FILE_SIZE, LongType))
+ .add(StructField(FILE_MODIFICATION_TIME, LongType))
Review comment:
I think this one is an easy decision. Timestamp type is much better as
people can do `WHERE _metadata.modificationTime < TIMESTAMP'2020-12-12
12:12:12'` or other datetime operations. And `df.show` can also display the
value in a more user-readable format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
