sarutak commented on a change in pull request #34745:
URL: https://github.com/apache/spark/pull/34745#discussion_r773080583
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MariaDBKrbIntegrationSuite.scala
##########
@@ -25,9 +25,9 @@ import
org.apache.spark.sql.execution.datasources.jdbc.connection.SecureConnecti
import org.apache.spark.tags.DockerTest
/**
- * To run this test suite for a specific version (e.g., mariadb:10.5.12):
+ * To run this test suite for a specific version (e.g., mariadb:10.5.13):
* {{{
- * ENABLE_DOCKER_INTEGRATION_TESTS=1
MARIADB_DOCKER_IMAGE_NAME=mariadb:10.5.12
+ * ENABLE_DOCKER_INTEGRATION_TESTS=1
MARIADB_DOCKER_IMAGE_NAME=mariadb:10.5.13
Review comment:
@tdg5 If you'd like to change here, please change [this
part](https://github.com/apache/spark/pull/34745/files#diff-cb12fa58307c2155fe2156d347d7a7917f1c755c34488a741dfb06653f83f364L41)
too.
##########
File path: project/SparkBuild.scala
##########
@@ -600,7 +600,7 @@ object DockerIntegrationTests {
lazy val settings = Seq(
dependencyOverrides += "com.google.guava" % "guava" % "18.0",
resolvers += "DB2" at
"https://app.camunda.com/nexus/content/repositories/public/";,
- libraryDependencies += "com.oracle" % "ojdbc6" % "11.2.0.1.0" from
"https://app.camunda.com/nexus/content/repositories/public/com/oracle/ojdbc6/11.2.0.1.0/ojdbc6-11.2.0.1.0.jar";
// scalastyle:ignore
+ libraryDependencies += "com.oracle" % "ojdbc6" % "11.2.0.3" from
"https://app.camunda.com/nexus/content/repositories/public/com/oracle/ojdbc6/11.2.0.3/ojdbc6-11.2.0.3.jar";
// scalastyle:ignore
Review comment:
Hmm, I'm confused about this part. Do we need this dependency setting
here?
`pom.xml` has the setting for `ojdbc8`.
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
##########
@@ -26,9 +26,10 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.tags.DockerTest
/**
- * To run this test suite for a specific version (e.g.,
2019-CU13-ubuntu-20.04):
+ * To run this test suite for a specific version (e.g.,
2019-CU14-ubuntu-20.04):
* {{{
- * ENABLE_DOCKER_INTEGRATION_TESTS=1
MSSQLSERVER_DOCKER_IMAGE_NAME=2019-CU13-ubuntu-20.04
+ * ENABLE_DOCKER_INTEGRATION_TESTS=1
+ *
MSSQLSERVER_DOCKER_IMAGE_NAME=mcr.microsoft.com/mssql/server:2019-CU14-ubuntu-20.04
Review comment:
Also, please change [this
part](https://github.com/apache/spark/pull/34745/files#diff-cb12fa58307c2155fe2156d347d7a7917f1c755c34488a741dfb06653f83f364L40)
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
