Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6074#discussion_r30168656
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -127,6 +127,57 @@ abstract class LogicalPlan extends 
QueryPlan[LogicalPlan] with Logging {
         resolve(nameParts, output, resolver, throwErrors)
     
       /**
    +   * Given an attribute name, split it to name parts by dot, but
    +   * don't split the name parts quoted by backticks, for example,
    +   * `ab.cd`.`efg` should be split into two parts "ab.cd" and "efg".
    +   */
    +  def resolveQuoted(
    +      name: String,
    +      resolver: Resolver): Option[NamedExpression] = {
    +    resolve(parseAttributeName(name), resolver, true)
    +  }
    +
    +  /**
    +   * Internal method, used to split attribute name by dot with backticks 
rule.
    +   * Backticks must appear in pairs, and the quoted string must be a 
complete name part,
    +   * which means `ab..c`e.f is not allowed.
    +   * Escape character is not supported now, so we can't use backtick 
inside name part.
    +   */
    +  private def parseAttributeName(name: String) = {
    --- End diff --
    
    put the return type here explicitly; the method is too long and not obvious 
enough for ret type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to