Yikun commented on a change in pull request #34939:
URL: https://github.com/apache/spark/pull/34939#discussion_r772055958
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -68,6 +69,8 @@ private[spark] object SparkKubernetesClientFactory extends
Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ // TODO(SPARK-37687): clean up direct usage of OkHttpClient, see also:
Review comment:
Here are some backgroud on this note (also add the jira:
[SPARK-37687](https://issues.apache.org/jira/browse/SPARK-37687)):
- There are [some problems (such as IPV6 based cluster
support)](https://github.com/fabric8io/kubernetes-client/issues/2632) on
okhttpclient v3, but it's a little bit diffcult to upgrade to v4.
- Kubernetes client are also consider to[ support other
clients](https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997402993)
rather than single okhttpclient.
- Kubernetes client[ add a abstract
layer](https://github.com/fabric8io/kubernetes-client/issues/3547) to support
variety httpclient, okhttp client as one of supported http clients.
So, we'd better to consider to cleanup okhttpclient direct usage and use the
httpclient which kubernetes client diret supported to reduce the potential risk
in future upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
