sadikovi opened a new pull request #34995: URL: https://github.com/apache/spark/pull/34995
### What changes were proposed in this pull request? This PR escapes `.` character in partition names as certain file systems (for example, ABFS) may not support it. I simply added the `.` character to the list of special characters in `ExternalCatalogUtils`. The class already covers backward compatibility so it would read the existing unescaped values with dots correctly. ### Why are the changes needed? Fixes an issue when ABFS throws `Caused by: java.lang.IllegalArgumentException: ABFS does not allow files or directories to end with a dot.` exception if a partition name contains `.` symbol. ### Does this PR introduce _any_ user-facing change? No. There should also be no backward compatibility issues since ExternalCatalogUtils allows reading both escaped and unescaped values. ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> Added a unit test in `InsertSuite` to confirm that dots are now escaped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
