mslapek commented on pull request #35000: URL: https://github.com/apache/spark/pull/35000#issuecomment-1001494019
> And could you briefly show what you fixed with Before & After example if possible ?? A brief example is given in the issue: https://issues.apache.org/jira/browse/SPARK-37730 I've run locally matplotlib tests: ``` $ python python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py ``` # After fix (my latest commit a1ca73d6): ## :heavy_check_mark: New pandas ``` $ python -c "import pandas as pd; print(pd.__version__)" 1.3.5 ``` ``` $ python python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py ... Ran 14 tests in 35.059s OK ``` ## :heavy_check_mark: Old pandas ``` $ python -c "import pandas as pd; print(pd.__version__)" 1.2.5 ``` ``` $ python python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py ... Ran 14 tests in 36.258s OK ``` # Main branch before fix (commit c0cedb13): ## :x: New pandas ``` $ python -c "import pandas as pd; print(pd.__version__)" 1.3.5 ``` ``` $ python python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py ... ERROR: test_single_value_hist (pyspark.pandas.tests.plot.test_series_plot_matplotlib.SeriesPlotMatplotlibTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/develop/repo/spark/python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py", line 391, in test_single_value_hist ax2 = psdf["single"].plot.hist() ... File "/home/develop/repo/spark/python/pyspark/pandas/plot/matplotlib.py", line 386, in _make_plot self._add_legend_handle(artists[0], label, index=i) AttributeError: 'PandasOnSparkHistPlot' object has no attribute '_add_legend_handle' ... ====================================================================== FAIL: test_pie_plot (pyspark.pandas.tests.plot.test_series_plot_matplotlib.SeriesPlotMatplotlibTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/develop/repo/spark/python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py", line 137, in test_pie_plot self.assertEqual(bin1, bin2) AssertionError: b'iVB[159 chars]dpAABSIUlEQVR4nO3dd3gc1d098DPbtLvqvdlqttwLbhhs[28020 chars]gg==' != b'iVB[159 chars]dpAABRr0lEQVR4nO3dd3xedf3//+e5VvZo2szOdO/SAYWC[27868 chars]gg==' ---------------------------------------------------------------------- Ran 14 tests in 33.338s FAILED (failures=2, errors=4) ``` ## :heavy_check_mark: Old pandas ``` $ python -c "import pandas as pd; print(pd.__version__)" 1.2.5 ``` ``` $ python python/pyspark/pandas/tests/plot/test_series_plot_matplotlib.py ... Ran 14 tests in 36.266s OK ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
