MaxGekk commented on a change in pull request #34973:
URL: https://github.com/apache/spark/pull/34973#discussion_r775475285
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRebaseDatetimeSuite.scala
##########
@@ -170,7 +173,8 @@ abstract class ParquetRebaseDatetimeSuite
// By default we should fail to read ancient datetime values when
parquet files don't
// contain Spark version.
"2_4_5" -> failInRead _,
- "2_4_6" -> successInRead _).foreach { case (version, checkDefaultRead) =>
+ "2_4_6" -> successInRead _,
+ "3_2_2" -> successInRead _).foreach { case (version, checkDefaultRead) =>
Review comment:
The generated files have `3.2.2` in metadata, in fact. I would keep it
as is. For us, more important that the files have the keys:
```
extra: org.apache.spark.legacyINT96 =
extra: org.apache.spark.legacyDateTime =
```
but **not any time zone**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
