zero323 commented on a change in pull request #35032:
URL: https://github.com/apache/spark/pull/35032#discussion_r775495516
##########
File path: python/pyspark/sql/functions.py
##########
@@ -2200,38 +2200,70 @@ def make_date(year: "ColumnOrName", month:
"ColumnOrName", day: "ColumnOrName")
return Column(jc)
+@overload
+def date_add(start: "ColumnOrName", days: "ColumnOrName") -> Column:
+ ...
+
+
+@overload
def date_add(start: "ColumnOrName", days: int) -> Column:
+ ...
Review comment:
We don't really need overloads here ‒ these are useful when there are
some relationships between arguments and / or return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
