Daniel-Davies edited a comment on pull request #35032: URL: https://github.com/apache/spark/pull/35032#issuecomment-1002209640
Great, thanks both- @zero323 let me know if there's anything else. I also have one other question; when is the Column type used vs ColumnOrName in function parameters? E.g., why are both types used in the following function? https://github.com/apache/spark/blob/master/python/pyspark/sql/functions.py#L3695 Would it be worth converting some of the existing Column type inputs to use ColumnOrName? It just seems a bit strange to need to write: `df.select(F.slice("x", F.col("i"), F.col("i")).alias("sliced"))` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
